View Issue Details

IDProjectCategoryView StatusLast Update
000521310000-009: Alarms and ConditionsApi Changepublic2021-01-28 20:10
ReporterBjarneBostrom Assigned ToPaul Hunkar  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0005213: AlarmConditionType Property AudibleSound (of AudioVariableType), that contains Properties, not allowed
Description

Alternatively title could have been ... AudibleSound Property TypeDefinition is not defined as PropertyType

1.04.3 nodeset of PublicationDate="2019-09-09T00:00:00Z" has some fixes where some parts of the nodeset was fixed to be in line with the specification. Noticed this due to it.

All Properties must be of type PropertyType. (1.04 Part 3 section 5.6.3 Properties "The HasTypeDefinition Reference points to the VariableType of the Property. Since Properties
are uniquely identified by their BrowseName, all Properties shall point to the PropertyType defined in Part 5.")

1.04 Part 9, section 5.8.2 AlarmConditionType Table 35 defines AudibleSound Property of TypeDefinition AudioVariableType. This is incorrect.

As a note in, 1.04 Part 5, section 7.19, AudioVariableType Table 78 defines Properties (ListId, AgencyId, VersionId), for the type.

The bug can either be 1) wrong TypeDefinion as Properties should be PropertyType OR 2) the reference type is wrong and e.g. HasComponent should be used.

In the NodeSet, node i=2915:

<UAObjectType NodeId="i=2915" BrowseName="AlarmConditionType">
<DisplayName>AlarmConditionType</DisplayName>
<References>
<Reference ReferenceType="HasComponent">i=9118</Reference>
<Reference ReferenceType="HasComponent">i=9160</Reference>
<Reference ReferenceType="HasProperty">i=11120</Reference>
<Reference ReferenceType="HasComponent">i=9169</Reference>
<Reference ReferenceType="HasComponent">i=16371</Reference>
<Reference ReferenceType="HasComponent">i=9178</Reference>
<Reference ReferenceType="HasProperty">i=9215</Reference>
<Reference ReferenceType="HasProperty">i=9216</Reference>
<Reference ReferenceType="HasProperty">i=16389</Reference>
<Reference ReferenceType="HasProperty">i=16390</Reference>
...

and node i=16390:
<UAVariable NodeId="i=16390" BrowseName="AudibleSound" ParentNodeId="i=2915" DataType="i=16307">
<DisplayName>AudibleSound</DisplayName>
<References>
<Reference ReferenceType="HasTypeDefinition">i=17986</Reference>
<Reference ReferenceType="HasModellingRule">i=80</Reference>
<Reference ReferenceType="HasProperty" IsForward="false">i=2915</Reference>
</References>
</UAVariable>

TagsNo tags attached.
Commit Version
Fix Due Date

Relationships

related to 0005230 closedPaul Hunkar 10000-009: Alarms and Conditions Property AudibleSound in AarmConditionType not of PropertyType 
has duplicate 0005385 closedPaul Hunkar 10000-009: Alarms and Conditions Wrong ReferenceType from AlarmConditionType to AudibleSound 
related to 0006413 closedRandy Armstrong NodeSets, XSDs and Generated Code AlarmConditionType AudibleSound not in sync with 1.04.8 

Activities

BjarneBostrom

2019-11-12 14:02

reporter   ~0011215

See https://apps.opcfoundation.org/mantis/view.php?id=5230 (somewhat a duplicate). And adding here the same note that it should be mentioned that the current NodeSet files may fail to load if this is validated while/before loading, which is problematic.

Paul Hunkar

2019-12-26 07:17

developer   ~0011381

Fixed to match Nodesetfile - which is a HasComponent reference instead of a HasProperty reference [note: the AudioVariableType changed after initial definition and this reference was missed on updates]

Jim Luth

2020-01-28 17:53

administrator   ~0011495

Needs 1.04 Errata to close.

Jim Luth

2020-06-19 14:50

administrator   ~0012479

Agreed to changes in virtual F2F.

Jim Luth

2020-06-19 15:27

administrator   ~0012487

Needs 1.04 Errata to close.

Jim Luth

2020-09-22 15:21

administrator   ~0012964

Agreed to 1.04 Errata in telecon.

Issue History

Date Modified Username Field Change
2019-11-01 11:58 BjarneBostrom New Issue
2019-11-12 14:02 BjarneBostrom Note Added: 0011215
2019-12-03 17:26 Jim Luth Project UA => 10000-009: Alarms and Conditions
2019-12-03 17:27 Jim Luth Assigned To => Paul Hunkar
2019-12-03 17:27 Jim Luth Status new => assigned
2019-12-03 17:27 Jim Luth Relationship added related to 0005230
2019-12-26 07:17 Paul Hunkar Status assigned => resolved
2019-12-26 07:17 Paul Hunkar Resolution open => fixed
2019-12-26 07:17 Paul Hunkar Fixed in Version => 1.05
2019-12-26 07:17 Paul Hunkar Note Added: 0011381
2020-01-28 17:20 Paul Hunkar Relationship added has duplicate 0005385
2020-01-28 17:53 Jim Luth Note Added: 0011495
2020-06-19 14:50 Jim Luth Status resolved => closed
2020-06-19 14:50 Jim Luth Note Added: 0012479
2020-06-19 15:27 Jim Luth Status closed => feedback
2020-06-19 15:27 Jim Luth Resolution fixed => reopened
2020-06-19 15:27 Jim Luth Status feedback => assigned
2020-06-19 15:27 Jim Luth Note Added: 0012487
2020-06-30 17:51 Paul Hunkar Status assigned => resolved
2020-06-30 17:51 Paul Hunkar Resolution reopened => fixed
2020-09-22 15:21 Jim Luth Status resolved => closed
2020-09-22 15:21 Jim Luth Note Added: 0012964
2021-01-28 20:10 Jim Luth Relationship added related to 0006413