View Issue Details

IDProjectCategoryView StatusLast Update
000457310000-014: PubSubSpecpublic2023-03-28 15:37
ReporterZbynek Zahradnik Assigned ToMatthias Damm  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Fixed in Version1.05.03 RC1 
Summary0004573: Shouldn't DataSetClassId be in 6.3.2.3 JSON DataSetMessage Reader ?
Description

I would intuitively expect that 6.3.2.3 JSON DataSetMessage Reader will also contain a DataSetClassId, similarly to 6.3.1.3.4 - also given that the DataSetClassId may be contained in the JSON NetworkMessage (Table 91) "header".

TagsNo tags attached.
Commit Version
Fix Due Date

Activities

Zbynek Zahradnik

2019-06-10 11:24

developer   ~0010366

Actually, there seems to be more confusion about where the DataSetClassID belongs. Under table 126 - DataSetReaderType Definition, the DataSetClassId is mentioned among properties (of the DataSetReaderType) - but there is no such property.

I would argue that the most logical solution (although not backwards compatible) would be to add this DataSetClassId to DataSetReaderType (and DataSetReaderDataType), and remove it from UadpDataSetReaderMessageType/DataType.

Note that filtering by DataSetClassId is also mentioned in Figure 8 (Subscriber message reception sequence) and in the text below it, further enforcing the concept that the DataSetClassid is not tied to specific message mappings.

Zbynek Zahradnik

2019-06-10 13:29

developer   ~0010367

Adding to the previous note - the DataSetClassId mentioned under Table 126 - DataSetReaderType Definition does not exist on the type, but there is DataSetClassId in the DataSetMetaDataType (the DataSetMetaData property). Given this, there is probably no reason to add DataSetClassId to the DataSetReaderType, but the text below Table 126 - DataSetReaderType Definition should be corrected to refer to the DataSetMetaData.DataSetClassId.

Matthias Damm

2019-09-09 10:56

developer   ~0010930

Last edited: 2019-09-09 10:56

UA WG Lisbon

We generally agreed that this is a missing setting but we do not want to create a new structure at this point in time.
If the structure is revised, we want to add the DataSetClassId. Another candidate is the PublishingInterval

Matthias Damm

2023-03-19 01:55

developer   ~0018884

Added DataSetClassId filter for JSON messages:

6.3.2.4.4 DataSetClassId
The parameter DataSetClassId with DataType Guid defines a DataSet class related filter. If the value is null of the paremeter is not set, the DataSetClassId filter is not applied.
The parameter is configured in the DataSetReadProperties with the Key DataSetClaasId.

This is currently configured through DataSetReadProperties. Otherwise we would need a JsonDataSetReaderMessage2DataType. We can include the DataSetClassId if we add a JsonDataSetReaderMessage2DataType in later versions.

Jim Luth

2023-03-28 15:37

administrator   ~0019046

Agreed to changes in web meeting.

Issue History

Date Modified Username Field Change
2018-12-27 12:22 Zbynek Zahradnik New Issue
2019-02-26 22:40 Matthias Damm Assigned To => Matthias Damm
2019-02-26 22:40 Matthias Damm Status new => assigned
2019-06-10 11:24 Zbynek Zahradnik Note Added: 0010366
2019-06-10 13:29 Zbynek Zahradnik Note Added: 0010367
2019-09-09 10:56 Matthias Damm Status assigned => acknowledged
2019-09-09 10:56 Matthias Damm Note Added: 0010930
2019-09-09 10:56 Matthias Damm Note Edited: 0010930
2022-11-15 17:41 Jim Luth Status acknowledged => assigned
2023-03-19 01:55 Matthias Damm Status assigned => resolved
2023-03-19 01:55 Matthias Damm Resolution open => fixed
2023-03-19 01:55 Matthias Damm Fixed in Version => 1.05.03 RC1
2023-03-19 01:55 Matthias Damm Note Added: 0018884
2023-03-28 15:37 Jim Luth Status resolved => closed
2023-03-28 15:37 Jim Luth Note Added: 0019046