View Issue Details

IDProjectCategoryView StatusLast Update
0004788NodeSets, XSDs and Generated CodeImplementation Bugpublic2019-07-23 15:18
ReporterChristian von Arnim Assigned ToRandy Armstrong  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0004788: Commas in CSV fields are not enclosed in double quotes
Description

I stumbled across th message when I watched the StatusCode.csv on github (Se also attached image, or https://github.com/OPCFoundation/UA-Nodeset/blob/044132f275185481c435d0396014e4e9f6836f9e/Schema/StatusCode.csv):
"We can make this file beautiful and searchable if this error is corrected: It looks like row 50 should actually have 3 columns, instead of 4. in line 49. "

The reason is, for example, in the following line, which has a comma in the description text. https://github.com/OPCFoundation/UA-Nodeset/blob/044132f275185481c435d0396014e4e9f6836f9e/Schema/StatusCode.csv#L50

The rfc4180 suggests adding double quotes for these fields.

From: https://tools.ietf.org/html/rfc4180

6.  Fields containing line breaks (CRLF), double quotes, and commas should be enclosed in double-quotes.

So I would suggest adding double quotes to all CSV fields that (can) contain a comma or other special characters.

This change might break some existing parsers of these files, but will improve overall compatibility.

This may also be a problem in other CSV files in the repository.

TagsSchema
Attached Files
GithubCsvError.PNG (78,459 bytes)   
GithubCsvError.PNG (78,459 bytes)   
Commit Version
Fix Due Date

Activities

Randy Armstrong

2019-07-17 22:46

administrator   ~0010500

Generated CSVs now wrap descriptions in double quotes.

Randy Armstrong

2019-07-23 15:18

administrator   ~0010561

Reviewed in July 23rd telecon.

Issue History

Date Modified Username Field Change
2019-06-19 09:43 Christian von Arnim New Issue
2019-06-19 09:43 Christian von Arnim Tag Attached: Schema
2019-06-19 09:43 Christian von Arnim File Added: GithubCsvError.PNG
2019-06-25 15:54 Jim Luth Assigned To => Randy Armstrong
2019-06-25 15:54 Jim Luth Status new => assigned
2019-07-17 22:46 Randy Armstrong Status assigned => resolved
2019-07-17 22:46 Randy Armstrong Resolution open => fixed
2019-07-17 22:46 Randy Armstrong Note Added: 0010500
2019-07-23 15:18 Randy Armstrong Status resolved => closed
2019-07-23 15:18 Randy Armstrong Note Added: 0010561