View Issue Details

IDProjectCategoryView StatusLast Update
0004954OpenSCSCompanion Specificationpublic2020-01-16 15:35
ReporterMatthias Becker Assigned ToDennis Brandl  
PrioritynormalSeveritytextReproducibilityhave not tried
Status assignedResolutionopen 
Summary0004954: OPENSCSLabelCollectionType does not transport usable data - OPENSCSLabelEventMethodType, OPENSCSAggregationMethodType
Description

The OPENSCSLabelCollection inherits from OPENSCSCollectionDataType which transports Serial Number Pool Data. But Label Events, SID Events and Aggregation Events are not 'Pool' events. As such fields like 'AssociatedPoolId' or 'State' are not relevant.
Instead the OPENSCSLableCollectionDataType (as well as the OPENSCSSNCollectionDataType) should NOT inherit but instead define an array of OPENSCSSNDataType directly

TagsNo tags attached.

Activities

Costantino Pipero

2019-08-22 12:33

manager   ~0010799

Section 6.3.4/5/6
Those variables should not be in the supertype (6.3.4) since LabelCollection (for ex.) doesnt need them. Better move those values to only the subtypes that need them.
In practice, OPENSCSSNCollectionDataType and OPENSCSLableCollectionDataType should be the same type (something like a OPENSCS<EVENTS>CollectionDataType ) and no variables; whereas there will be a type (with those variables) for the serial management side.

Costantino Pipero

2019-08-22 12:35

manager   ~0010800

ALSO, the OPENSCSSNLabelPropertyDataType is in reality a key/value pair and it should be an optional property of the new OPENSCS<EVENTS>CollectionDataType.

Dennis Brandl

2019-09-18 21:31

developer   ~0010998

I disagree with the assertion that the Label Collection does not need to information contained in the Collection Type.
I also disagree with the statement that the Label, SID, and Aggregation events are not "pool" events. Given the fact that this standard will be used for internal serial number management as well an industry or county wide serial number management, I can envision a scenario where you need to know the pool and state in order to determine what to do about the event. For example, I may need to handle Aggregation Events for Walmart pallets different form Costco pallets, and they use Walmart and Costco provided serial number rules and pools.

We need to discuss

Matthias Becker

2019-09-19 09:38

developer   ~0011005

The problem is the scope of the usage of these data types. The event method data types are semantically different to the sn pool method data types. As such mixing these results unclear fields of responsibilities and usages.
Also, the OPENSCSCollectionDataType contains data which is redundant to the SID event methods or just plain confusing (the 'State' especially)... Adding the 'Pool' information to the SID is fine but keep in mind that this information is not always available for 'Event'-Method invoker

Costantino Pipero

2020-01-16 15:35

manager   ~0011452

Agreed to change 6.3.1.9 Input arg to OPENSCSSNCollectionDataType instead of OPENSCSLabelCollectionDataType.
Also LabelCollectsionType is no longer a subtype of SCSCollectionType.

Issue History

Date Modified Username Field Change
2019-08-12 15:20 Matthias Becker New Issue
2019-08-12 15:20 Matthias Becker Status new => assigned
2019-08-12 15:20 Matthias Becker Assigned To => Costantino Pipero
2019-08-22 12:33 Costantino Pipero Note Added: 0010799
2019-08-22 12:35 Costantino Pipero Note Added: 0010800
2019-08-22 12:36 Costantino Pipero Assigned To Costantino Pipero => Dennis Brandl
2019-09-18 21:31 Dennis Brandl Note Added: 0010998
2019-09-18 21:31 Dennis Brandl Status assigned => feedback
2019-09-19 09:38 Matthias Becker Note Added: 0011005
2019-09-19 09:38 Matthias Becker Status feedback => assigned
2020-01-16 15:35 Costantino Pipero Note Added: 0011452