View Issue Details

IDProjectCategoryView StatusLast Update
000586210000-019: Dictionary ReferenceSpecpublic2020-09-15 17:16
ReporterMelvin Assigned ToJeff Harding  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
Summary0005862: ValueRank mismatch between MultiStateDictionaryEntryDiscreteBaseType and its base type
Description

The ValueRank attribute (-1) of MultiStateDictionaryEntryDiscreteBaseType (https://reference.opcfoundation.org/v104/Core/VariableTypes/MultiStateDictionaryEntryDiscreteBaseType/) does not match the ValueRank attribute (-1) of its base type MultiStateValueDiscreteType (https://reference.opcfoundation.org/v104/Core/VariableTypes/MultiStateValueDiscreteType/).

TagsPA-DIM
Commit Version
Fix Due Date

Relationships

related to 0005927 closedKarl Deiretsbacher 10000-008: Data Access ValueRank mismatch between MultiStateDictionaryEntryDiscreteBaseType and its base type 
related to 0005928 closedRandy Armstrong NodeSets, XSDs and Generated Code ValueRank mismatch between MultiStateDictionaryEntryDiscreteBaseType and its base type 

Activities

Melvin

2020-08-06 09:33

reporter   ~0012665

It seems I can not edit my own issue. I meant to say that the ValueRank attribute of MultiStateValueDiscreteType is -2, not -1.

Christian von Arnim

2020-08-06 11:53

reporter   ~0012666

This issue was initially discussed here: https://github.com/open62541/open62541/issues/3826

The problem occures, when implementing the PADIM companion specification

MultiStateValueDiscreteType (ns=0;i=11238, ValueRank=-2[ANY]) --HasSubtype-->MultiStateDictionaryEntryDiscreteBaseType (ns=0;i=19077, ValueRank=-1[SCALAR]) --HasSubtype-->MultiStateDiscreteSignalVariableType(ns=PADIM;i1142, ValueRank=-2[ANY])

According to https://reference.opcfoundation.org/v104/Core/docs/Part3/6.2.7/ either MultiStateDictionaryEntryDiscreteBaseType should be ValueRank=-2, or MultiStateDiscreteSignalVariableType should have ValueRank=-1

Jim Luth

2020-08-25 15:44

administrator   ~0012722

Either PA-DIM needs to change to ValueRank = -1, or Part 19 needs to change to ValueRank=-2. Not sure which makes sense.

Jeff Harding

2020-08-25 17:53

developer   ~0012727

During the August 27, 2019 TWG review of the Part 19 draft the ValueRank of the MultiStateDictionaryEntryDiscreteBaseType was changed to a Scalar.
During this review it was noted that since it is a subtype of MultiStateValueDiscreteType (defined in Part 8) which has a ValueRank of Scalar then it also needs to be Scalar.
Reference to meeting recording is https://youtu.be/_pT2ka45LyE start listening at 1:52:00.

I suggest we advise FCG that the PA-DIM spec needs to be updated.

-

Jim Luth

2020-09-01 16:27

administrator   ~0012735

Last edited: 2020-09-01 16:34

Agreed to change specs to match nodeset (that has always been "any" since 1.03). Affects Part 8 and Part 19. Need Errata for 1.03 and 1.04.
Nodeset also needs to be changed (1.04) for MultistateDictionaryEntryDiscreteBaseType and MultistateDictionaryEntryDiscreteType from Scalar to Any.

Jeff Harding

2020-09-02 17:48

developer   ~0012750

While making the changes to Part 19 I realized that while we can change MultiStateDictionaryEntryDiscreteBaseType to have a ValueRank of Any we can not do that with MultiStateDictionaryEntryDiscreteType. This is because of the ValueAsDictionaryEntries component which is mandatory in MultiStateDictionaryEntryDiscreteType. This component provides NodeIds (one per dictionary) for the current value. Since each value of an array may have a different value then the NodeIds would need to be a 2 dimensional array which it is not.

Jeff Harding

2020-09-15 17:12

developer   ~0012825

After discussions with PA-DIM they have decided to change their spec to Scalar so no change is required here.

Jim Luth

2020-09-15 17:15

administrator   ~0012826

Agreed to no-fix in Virtual F2F.

Issue History

Date Modified Username Field Change
2020-08-06 09:28 Melvin New Issue
2020-08-06 09:33 Melvin Note Added: 0012665
2020-08-06 11:53 Christian von Arnim Note Added: 0012666
2020-08-06 11:54 Christian von Arnim Tag Attached: PA-DIM
2020-08-25 15:44 Jim Luth Note Added: 0012722
2020-08-25 15:45 Jim Luth Project NodeSets, XSDs and Generated Code => 10000-019: Dictionary Reference
2020-08-25 15:45 Jim Luth Category Implementation Bug => Api Change
2020-08-25 15:45 Jim Luth Assigned To => Jeff Harding
2020-08-25 15:45 Jim Luth Status new => assigned
2020-08-25 17:53 Jeff Harding Note Added: 0012727
2020-08-25 17:54 Jeff Harding Status assigned => resolved
2020-08-25 17:54 Jeff Harding Resolution open => no change required
2020-08-25 17:54 Jeff Harding Fixed in Version => 1.04
2020-09-01 16:27 Jim Luth Note Added: 0012735
2020-09-01 16:34 Jim Luth Note Edited: 0012735
2020-09-01 16:34 Jim Luth Status resolved => assigned
2020-09-01 18:06 Jim Luth Issue cloned: 0005927
2020-09-01 18:06 Jim Luth Relationship added related to 0005927
2020-09-01 18:07 Jim Luth Issue cloned: 0005928
2020-09-01 18:07 Jim Luth Relationship added related to 0005928
2020-09-02 17:48 Jeff Harding Note Added: 0012750
2020-09-15 17:12 Jeff Harding Status assigned => resolved
2020-09-15 17:12 Jeff Harding Note Added: 0012825
2020-09-15 17:15 Jim Luth Status resolved => closed
2020-09-15 17:15 Jim Luth Note Added: 0012826
2020-09-15 17:16 Jim Luth Category Api Change => Spec
2020-09-15 17:16 Jim Luth Fixed in Version 1.04 =>