View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007514 | Part 81: UAFX Connecting Devices and Information Model [sg.BaseFacet] | Spec | public | 2022-01-04 09:24 | 2022-05-30 22:57 |
| Reporter | Thomas Schreck | Assigned To | Georg Biehler | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Target Version | 1.00.00 RC3 | Fixed in Version | 1.00.00 RC3 | ||
| Summary | 0007514: Modify and move requirement on finishing processing of AssetVerifications array if an error is encountered. | ||||
| Description | The requirement: "The EstablishConnections implementation shall process all elements in the AssetVerifications array, even if an error is encountered on an element in the array." is currently placed in Section 6.2.4.3.2 Command VerifyAssetCmd of Part 81. The processing is done by the VerifyAsset Method instead of the EstablishConnections Method. The right place for the updated requirement is Section 6.3.3 VerifyAsset method. | ||||
| Tags | No tags attached. | ||||
| related to | 0007535 | closed | David Puffer | VerifyAsset Method: Description for AssetCompatibility- & AssetIdentity.Mismatch |
|
|
The signature of the EstablishConnections contains AssetVerifications, which is processed by the AssetVerificationCmd. AssetVerifications is an array of AssetVerificationDataType. The number of elements in the array specifies how many times to calls VerifyAsset(). Each array element contains the information which Asset to verify (AssetToVerify), i.e. where to call the Method plus the [in] arguments for the Method (VerificationMode, ExpectedVerificationVariables, ExpectedAdditionalVerificationVariables) plus the ExpectedVerificationResult to be compared with the VerficationResult ([out] argument of the VerifyAsset Method). The passed stated above wants to tell (and maybe I didn't succeed), that the EstablishConnections Method shall call the VerifyAsset Method for each element in the array (even if one of the Verifies fails). Meaning, if I have five elements in the array, and the third call fails, still call the VerifyAsset for the forth and fifth element. I propose to remove this sentence completely, since the preceeding two paragraphs are already sufficient ("shall execute for each element") If CommandMask VerifyAssetCmd is set, the EstablishConnections implementation shall execute the IAssetRevisionType VerifyAsset Method for each element in the AssetVerifications array. The VerifyAsset Method shall be called on each AssetToVerify, supplying the VerificationMode, ExpectedVerificationVariables and ExpectedAdditionalVerificationVariables as Method Arguments. BTW: We should also remove the paragraph "The EstablishConnections implementation shall process all elements in the ConnectionEndpointConfigurations that contain non-empty ExpectedVerificationVariables, even if an error is encountered on an element in the array." from the section below; again this is stated already in the first paragraph. |
|
|
Updated section 6.2.4.3.2 Command VerifyAssetCmd and 6.2.4.3.3 Command VerifyFunctionalEntityCmd |
|
|
Thomas accepted the changes above, however, for VerifyAsset one open issue remains: It is unclear, whether VerifyAsset should continue with the verification if the first error appears, or stop verification and use Bad_NothingToDo for the rest? In our discussion we left it open for the implementation to choose what to do, do we need more clarification in the spec about it? Continued in the related issue |
|
|
See previous notes |
|
|
review in info model call, agreed to close |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-01-04 09:24 | Thomas Schreck | New Issue | |
| 2022-01-07 14:04 | Paul Hunkar | Assigned To | => Paul Hunkar |
| 2022-01-07 14:04 | Paul Hunkar | Status | new => assigned |
| 2022-01-10 09:43 | Georg Biehler | Note Added: 0015685 | |
| 2022-01-10 09:49 | Georg Biehler | Note Added: 0015686 | |
| 2022-01-11 09:19 | Georg Biehler | Note Added: 0015689 | |
| 2022-01-11 14:16 | Paul Hunkar | Assigned To | Paul Hunkar => Georg Biehler |
| 2022-01-11 14:22 | Paul Hunkar | Note Edited: 0015685 | |
| 2022-01-11 14:35 | Paul Hunkar | Relationship added | related to 0007535 |
| 2022-01-11 14:55 | Georg Biehler | Note Edited: 0015689 | |
| 2022-01-11 14:55 | Georg Biehler | Status | assigned => resolved |
| 2022-01-11 14:55 | Georg Biehler | Resolution | open => fixed |
| 2022-01-11 14:55 | Georg Biehler | Fixed in Version | => 1.00.00 Release |
| 2022-01-11 14:55 | Georg Biehler | Note Added: 0015694 | |
| 2022-01-11 14:56 | Paul Hunkar | Status | resolved => closed |
| 2022-01-11 14:56 | Paul Hunkar | Note Added: 0015695 | |
| 2022-05-30 22:57 | Paul Hunkar | Fixed in Version | 1.00.00 Release => 1.00.00 RC3 |
| 2022-05-30 22:57 | Paul Hunkar | Target Version | => 1.00.00 RC3 |