View Issue Details

IDProjectCategoryView StatusLast Update
0007656Part 81: UAFX Connecting Devices and Information ModelSpecpublic2022-03-29 15:08
ReporterMatthias Damm Assigned ToGeorg Biehler  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionreopened 
Product Version1.00.00 RC2 
Target Version1.00.00 ReleaseFixed in Version1.00.00 Release 
Summary0007656: Missing status code fields in EstablishConnection result structures
Description

Command SetCommunicationConfigurationCmd and ConnectionEndpointConfigurationResultDataType
The description of the command states several times "an appropriate StatusCode shall be set" but there is no StatusCode field for SetCommunicationConfiguration in the ConnectionEndpointConfigurationResultDataType.
There is one for EnableCommunicationResult but I assume this one should not be used.

The CommunicationConfigurationResultDataType (PubSubCommunicationConfigurationResultDataType) had an overall result StatusCode field in a previous version. This is missing. It is necessary to indicate general issues with processing the PubSubCommunicationConfiguration.

TagsNo tags attached.

Activities

Georg Biehler

2022-01-26 06:59

developer   ~0015863

You are right: Table 15 "CommunicationConfigurationResults Result StatusCodes" implies the existence of the field Result in the CommunicationConfigurationResults, however, the DataType Definition of CommunicationConfigurationResultDataType does not define it.

Georg Biehler

2022-01-26 07:01

developer   ~0015864

Added the missing Result to PubSubCommunicxationConfigurationResults (10.8.3)
Added clarification where to set the StatusCode in section 6.2.4.3.9.2

Matthias Damm

2022-01-26 11:05

developer   ~0015870

I agree with the updates related to the PubSubCommunicationConfigurationResultDataType to report general issues with the PubSubCommunicationConfiguration.

But to use ConnectionEndpointConfigurationResultDataType.ConnectionEndpointResult also for SetCommunicationConfiguration Cmd errors related to an endpoint is a problem.
If the creation of the endpoint succeeded but the SetCommunicationConfiguration for the endpoint in the same EstablishConnection fails, it is missleading to create the endpoint but the return an error in ConnectionEndpointConfigurationResultDataType.ConnectionEndpointResult.

According to the Abort rollback actions, the endpoint would stay created and only the communication settings are reverted.

Georg Biehler

2022-01-26 11:15

developer   ~0015872

needs discussion in a team meeting
The general error (there is just one) would not reflect, which CEP does not fit according to the Variables to the communication model.

Georg Biehler

2022-01-26 13:26

developer   ~0015875

As discussed in the prototyping meeting:
Make clear in SetCommunicationCmd where to set which StatusCode (feedback Matthias Damm, Michal Tyndal)
Add a CommunicationConfigurationResult in the ConnectionEndpointConfigurationResult and move some errors from the ConnectionEndpointResult to this one

Georg Biehler

2022-01-27 09:29

developer   ~0015881

Clarification integrated into specification, checked back with Matthias and got approval.

Paul Hunkar

2022-02-11 14:20

manager   ~0015982

The name for CommunicationConfigurationResult is used twice with just a very minor difference - one should be renamed (to easy to confuse)

Georg Biehler

2022-02-14 11:40

developer   ~0016001

After some thinking I decided to have the error for a non-matching communication model included in the CommunicationLinksResult; thus no additional error needed.

By adding that to the spec, I detected a lot of inconsistent places, some status tables missing ... some status codes missing. Cleaned them up in section 6.4.2

Paul Hunkar

2022-03-29 15:08

manager   ~0016468

Reviewed in in multiple call (last being today) , Agreed to all changes and closed issue

Issue History

Date Modified Username Field Change
2022-01-25 19:11 Matthias Damm New Issue
2022-01-25 19:11 Matthias Damm Product Version => 1.00.00 RC2
2022-01-25 19:11 Matthias Damm Target Version => 1.00.00 Release
2022-01-26 06:59 Georg Biehler Note Added: 0015863
2022-01-26 07:00 Georg Biehler Assigned To => Georg Biehler
2022-01-26 07:00 Georg Biehler Status new => assigned
2022-01-26 07:01 Georg Biehler Status assigned => resolved
2022-01-26 07:01 Georg Biehler Resolution open => fixed
2022-01-26 07:01 Georg Biehler Fixed in Version => 1.00.00 Release
2022-01-26 07:01 Georg Biehler Note Added: 0015864
2022-01-26 11:05 Matthias Damm Status resolved => feedback
2022-01-26 11:05 Matthias Damm Resolution fixed => reopened
2022-01-26 11:05 Matthias Damm Note Added: 0015870
2022-01-26 11:15 Georg Biehler Note Added: 0015872
2022-01-26 13:26 Georg Biehler Note Added: 0015875
2022-01-27 09:29 Georg Biehler Status feedback => resolved
2022-01-27 09:29 Georg Biehler Note Added: 0015881
2022-02-11 14:20 Paul Hunkar Status resolved => feedback
2022-02-11 14:20 Paul Hunkar Note Added: 0015982
2022-02-11 14:21 Paul Hunkar Status feedback => assigned
2022-02-14 11:40 Georg Biehler Status assigned => resolved
2022-02-14 11:40 Georg Biehler Note Added: 0016001
2022-03-29 15:08 Paul Hunkar Status resolved => closed
2022-03-29 15:08 Paul Hunkar Note Added: 0016468