View Issue Details

IDProjectCategoryView StatusLast Update
0007680CTT UA ScriptsApi Changepublic2022-09-02 15:25
ReporterHans Berende Assigned ToAlexander Allmendinger  
PrioritylowSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Fixed in Version1.03.501 
Summary0007680: Subscription Basic 023.js "ModifySubscription: Default parameter values." seems wrong
Description

The test case sends 3 successive Write commands and measures the publishing interval. The assert is programmed as:

Assert.InRange( 5700, 7300, mdifference, "Expected a PublishingInterval of 2000 but actual interval was " + ( mdifference / NUMWRITES ) );

The result (see attachement) shows, that the average time of 7100 is in range but the received value is 21300.
Modifying to

Assert.InRange( 5700, 7400, (mdifference / NUMWRITES), "Expected a PublishingInterval of 2000 but actual interval was " + ( mdifference / NUMWRITES ) );

solved that.

TagsNo tags attached.
Attached Files
Subscription Basic Test 023.js (18,991 bytes)   
Subscription Basic Test 023.js (18,991 bytes)   
Files Affected

Activities

Alexander Allmendinger

2022-02-25 18:54

developer   ~0016114

After looking into the script I don't see an issue in the calculation. The numbers assume that we have 3 Publishes with a 2000 ms difference. The numbers do already put into account, that we are looking at 3 writes as 3*2000 = 6000 ms, while the lower limit 5700 provides 300 ms grace and the upper limit 7400 allows 1300 ms grace.

If we would divide the mdifference by NUMWRITES, we would need to do the same for the upper and lower limit what again would mean the provided publishing rate of 7100 ms is out of range.

Hans Berende

2022-02-28 05:49

reporter   ~0016115

Hi,

do you think that users actually understand "The result (see attachement) shows, that the average time of 7100 is in range but the received value is 21300."

where 21300 actually means 3 *7100?

Do users really need to study each error text in source code in order to understand what is going wrong?

Paul Hunkar

2022-02-28 23:57

administrator   ~0016121

We can clarify the first statement to say:
"Expected total duration over 3 publishing intervale of 6000 ms (average publishing interval 2000) but actual total was 21300 (publish interval average was 7100)"
second statement is just a log of the numbers that were being checked

this is just a clarification (not considered a change)

Hans Berende

2022-03-01 06:21

reporter   ~0016124

That would be sufficient.

Thanks for taking it in concideratation.

Sebastian Allmendinger

2022-03-11 06:32

developer   ~0016334

The error message has been updated to a more accurate text that should clearly state the problem.
In addition, the test script also aborts if the revised PublishingInterval does not match the requested one.

Paul Hunkar

2022-09-02 15:25

administrator   ~0017498

reviewed code in call , agreed to updates and closed issue

Issue History

Date Modified Username Field Change
2022-01-31 09:14 Hans Berende New Issue
2022-01-31 09:14 Hans Berende File Added: Subscription Basic Test 023.js
2022-02-25 16:43 Paul Hunkar Assigned To => Alexander Allmendinger
2022-02-25 16:43 Paul Hunkar Status new => assigned
2022-02-25 18:54 Alexander Allmendinger Status assigned => resolved
2022-02-25 18:54 Alexander Allmendinger Resolution open => no change required
2022-02-25 18:54 Alexander Allmendinger Note Added: 0016114
2022-02-28 05:49 Hans Berende Status resolved => feedback
2022-02-28 05:49 Hans Berende Resolution no change required => reopened
2022-02-28 05:49 Hans Berende Note Added: 0016115
2022-02-28 23:57 Paul Hunkar Status feedback => assigned
2022-02-28 23:57 Paul Hunkar Note Added: 0016121
2022-02-28 23:59 Paul Hunkar Priority high => low
2022-02-28 23:59 Paul Hunkar Severity major => trivial
2022-03-01 06:21 Hans Berende Note Added: 0016124
2022-03-11 06:32 Sebastian Allmendinger Status assigned => resolved
2022-03-11 06:32 Sebastian Allmendinger Resolution reopened => fixed
2022-03-11 06:32 Sebastian Allmendinger Note Added: 0016334
2022-08-02 20:23 Paul Hunkar Project Compliance Test Tool (CTT) Unified Architecture => CTT UA Scripts
2022-08-02 20:23 Paul Hunkar Project CTT UA Scripts => .NET API
2022-08-02 20:23 Paul Hunkar Category 1 - Script Issue => Api Change
2022-08-04 14:24 Paul Hunkar Project .NET API => Compliance Test Tool (CTT) Unified Architecture
2022-09-02 15:24 Paul Hunkar Project Compliance Test Tool (CTT) Unified Architecture => CTT UA Scripts
2022-09-02 15:25 Paul Hunkar Status resolved => closed
2022-09-02 15:25 Paul Hunkar Fixed in Version => 1.03.501
2022-09-02 15:25 Paul Hunkar Note Added: 0017498